use bazel 8 (bzlmod migration) #134

tekumara · 2024-12-14T09:40:42Z

Migrates to bzlmod which is required by Bazel 8 see https://bazel.build/external/migration

Go deps are now defined in go.mod

Resolves #131

tekumara · 2024-12-14T09:42:18Z

MODULE.bazel

+bazel_dep(name = "rules_proto", version = "5.3.0-21.7")
+bazel_dep(
+    name = "protobuf",
+    version = "26.0",


previously we were using 25.2 but that doesn't exist on bazel central

tekumara · 2024-12-14T12:32:02Z

NB: This PR has lots of WIP commits - I recommend squash merging it.

This reverts commit 6c130f3.

jp-fizzbee · 2024-12-16T08:23:52Z

modelchecker/BUILD.bazel

-        "@com_github_jayaprabhakar_go_clone//:go-clone",
-        "@org_golang_google_protobuf//encoding/protojson:go_default_library",
-        "@org_golang_google_protobuf//proto:go_default_library",
+        "@com_github_huandu_go_clone//:go-clone",


@tekumara One reason I had to fork the cloning library was it was missing a feature to override pointer references.
huandu/go-clone#23

It's still using your fork - see the replace statement in go.mod

I had to do it like this to make go.mod work

https://go.dev/ref/mod#go-mod-file-replace

I'm assuming bazel honours this but admittedly I haven't tested this - is there a way to test this?

Got it. Thanks.

jayaprabhakar · 2024-12-16T08:53:43Z

Thanks for the PR. I only have one issue. Is there a reason to switch one of the dependency?

jp-fizzbee · 2024-12-16T16:53:58Z

I ran it, I see this error.

Starting local Bazel server and connecting to it...
WARNING: For repository 'protobuf', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: Couldn't auto load rules or symbols, because no dependency on module/repository 'rules_android' found. This will result in a failure if there's a reference to those rules or symbols.
INFO: Analyzed 2 targets (135 packages loaded, 5344 targets configured).
INFO: From Linking external/protobuf+/src/google/protobuf/io/libio_win32.a [for tool]:
warning: /Library/Developer/CommandLineTools/usr/bin/libtool: archive library: bazel-out/darwin_arm64-opt-exec-ST-d57f47055a04/bin/external/protobuf+/src/google/protobuf/io/libio_win32.a the table of contents is empty (no object file members in the library define global symbols)
ERROR: /private/var/tmp/_bazel_jp/44f378705132ae1485a21c4be97e06a5/external/protobuf+/src/google/protobuf/io/BUILD.bazel:99:11: Compiling src/google/protobuf/io/printer.cc [for tool] failed: (Exit 1): cc_wrapper.sh failed: error executing CppCompile command (from target @@protobuf+//src/google/protobuf/io:printer) external/rules_cc++cc_configure_extension+local_config_cc/cc_wrapper.sh -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -Wunused-but-set-parameter -Wno-free-nonheap-object ... (remaining 50 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from external/protobuf+/src/google/protobuf/io/printer.cc:12:
bazel-out/darwin_arm64-opt-exec-ST-d57f47055a04/bin/external/protobuf+/src/google/protobuf/io/_virtual_includes/printer/google/protobuf/io/printer.h:918:19: error: 'get<std::function<bool ()>, std::string, std::function<bool ()>>' is unavailable: introduced in macOS 10.13
    value = absl::get<Callback>(that.value);
                  ^
bazel-out/darwin_arm64-opt-exec-ST-d57f47055a04/bin/external/protobuf+/src/google/protobuf/io/_virtual_includes/printer/google/protobuf/io/printer.h:863:11: note: in instantiation of function template specialization 'google::protobuf::io::Printer::ValueImpl<false>::operator=<true>' requested here
    *this = that;
          ^
bazel-out/darwin_arm64-opt-exec-ST-d57f47055a04/bin/external/protobuf+/src/google/protobuf/io/_virtual_includes/printer/google/protobuf/io/printer.h:1150:12: note: in instantiation of function template specialization 'google::protobuf::io::Printer::ValueImpl<false>::ValueImpl<true>' requested here
    return ValueView(it->second);
           ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/variant:1577:22: note: 'get<std::function<bool ()>, std::string, std::function<bool ()>>' has been explicitly marked unavailable here
constexpr const _Tp& get(const variant<_Types...>& __v) {
                     ^
1 error generated.
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 20.992s, Critical Path: 2.82s
INFO: 704 processes: 458 internal, 246 darwin-sandbox.
ERROR: Build did NOT complete successfully
⏺ jp@ /Users/jp/src1/fizzbee (main) #

jayaprabhakar · 2024-12-16T18:47:49Z

It looks like this is an issue with Mac.
protocolbuffers/protobuf#16944

The current workaround should be to add

build --host_cxxopt=-std=c++14 --cxxopt=-std=c++14

To .bazelrc

I'm not sure if this works in Linux.

tekumara · 2024-12-16T20:43:30Z

Interesting I didn't hit that on my Mac.

I notice we are using an old version of protobuf.

I've tried the PR without that .bazelrc on Ubuntu arm64 and it built fine.

jp-fizzbee · 2024-12-17T07:05:58Z

For now, I added build --host_cxxopt=-std=c++14 --cxxopt=-std=c++14 to my local .bazelrc to make it work. I am not sure if it is an issue on mine or others too.

tekumara added 25 commits December 13, 2024 21:02

set bazel version 7.x

f6fc4e5

.

c868f86

.

af7037b

.

25b4b5d

.

f83e5f4

.

6a49984

.

cdaa29d

.

e79db87

.

d9ef5b6

.

4b13a78

.

f26fe40

add go.mod

01d338a

replace huandu/go-clone

7d0fa1d

go_deps.from_file(go_mod = "//:go.mod")

8b964ca

building

85270a3

bazel mod tidy

eb9ab86

rename rules_go

e5eeebc

rename bazel_gazelle

eca18ba

.

93f48c5

working

ecc1759

Merge branch 'main' of https://github.com/tekumara/fizzbee into bazel7

0ec6048

fix python

f5a66e3

.

2a51dde

use python 3.12

6a850b7

.

636d8bd

tekumara commented Dec 14, 2024

View reviewed changes

tekumara added 3 commits December 15, 2024 07:15

remove rules_proto

70ce403

fix perf py_proto_library

03fec4e

.

6c130f3

tekumara added 5 commits December 15, 2024 10:17

Revert "."

d0b7a85

This reverts commit 6c130f3.

add graph_proto

76dda19

add go.sum

fdafaf6

.

abb25e3

fix so run gazelle works

bff2d1e

jp-fizzbee reviewed Dec 16, 2024

View reviewed changes

jp-fizzbee approved these changes Dec 16, 2024

View reviewed changes

jp-fizzbee merged commit fb19e8a into fizzbee-io:main Dec 16, 2024

tekumara deleted the bazel8 branch December 16, 2024 23:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

use bazel 8 (bzlmod migration) #134

use bazel 8 (bzlmod migration) #134

Uh oh!

tekumara commented Dec 14, 2024 •

edited

Loading

Uh oh!

tekumara Dec 14, 2024

Uh oh!

tekumara commented Dec 14, 2024

Uh oh!

jp-fizzbee Dec 16, 2024

Uh oh!

tekumara Dec 16, 2024

Uh oh!

tekumara Dec 16, 2024

Uh oh!

tekumara Dec 16, 2024

Uh oh!

jayaprabhakar Dec 16, 2024

Uh oh!

jayaprabhakar commented Dec 16, 2024

Uh oh!

jp-fizzbee commented Dec 16, 2024

Uh oh!

jayaprabhakar commented Dec 16, 2024

Uh oh!

tekumara commented Dec 16, 2024

Uh oh!

jp-fizzbee commented Dec 17, 2024

Uh oh!

Uh oh!

use bazel 8 (bzlmod migration) #134

use bazel 8 (bzlmod migration) #134

Uh oh!

Conversation

tekumara commented Dec 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tekumara Dec 14, 2024

Choose a reason for hiding this comment

Uh oh!

tekumara commented Dec 14, 2024

Uh oh!

jp-fizzbee Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

tekumara Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

tekumara Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

tekumara Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

jayaprabhakar Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

jayaprabhakar commented Dec 16, 2024

Uh oh!

jp-fizzbee commented Dec 16, 2024

Uh oh!

jayaprabhakar commented Dec 16, 2024

Uh oh!

tekumara commented Dec 16, 2024

Uh oh!

jp-fizzbee commented Dec 17, 2024

Uh oh!

Uh oh!

tekumara commented Dec 14, 2024 •

edited

Loading